0x43 issueshttps://gitlab.0x43.nl/groups/0x43/-/issues2019-05-09T08:45:30Zhttps://gitlab.0x43.nl/0x43/ebookhub-frontend/-/issues/6User password repeat2019-05-09T08:45:30ZMycha de VreesUser password repeatWhen a user resets their password, a second password repeat field should be addedWhen a user resets their password, a second password repeat field should be addedhttps://gitlab.0x43.nl/0x43/ebookhub-frontend/-/issues/3Unit tests2019-04-12T17:38:10ZMycha de VreesUnit testshttps://jestjs.io/https://jestjs.io/1.0.0https://gitlab.0x43.nl/0x43/ebookhub-backend/-/issues/20Sorting resultset2019-04-11T12:23:00ZMycha de VreesSorting resultsetWhen sorting the resultset, it looks like the sorting is always ASC. Need a way to also sort it DESC.
![Screenshot_from_2019-04-11_14-22-21](/uploads/e30adfd061a9a441179477c5ad452791/Screenshot_from_2019-04-11_14-22-21.png)When sorting the resultset, it looks like the sorting is always ASC. Need a way to also sort it DESC.
![Screenshot_from_2019-04-11_14-22-21](/uploads/e30adfd061a9a441179477c5ad452791/Screenshot_from_2019-04-11_14-22-21.png)Patrick van der LeerPatrick van der Leerhttps://gitlab.0x43.nl/0x43/ebookhub-backend/-/issues/12save structure of library2019-03-18T14:03:03ZPatrick van der Leersave structure of libraryHow should we setup the structure of the library, group files by author (sortable) name? -> what if multiple authors?
@mycha thoughts?How should we setup the structure of the library, group files by author (sortable) name? -> what if multiple authors?
@mycha thoughts?Mycha de VreesMycha de Vreeshttps://gitlab.0x43.nl/0x43/ebookhub-backend/-/issues/2safrs2019-03-12T11:51:00ZPatrick van der Leersafrshttps://github.com/thomaxxl/safrshttps://github.com/thomaxxl/safrshttps://gitlab.0x43.nl/0x43/ebookhub-backend/-/issues/23non ASCII character in XML from external source2019-05-02T14:06:16ZPatrick van der Leernon ASCII character in XML from external sourcevalue in XML from goodreads: `Ausz\xc3\xbcge`
```
xml.parsers.expat.ExpatError: not well-formed (invalid token): line 41, column 1158
Job "BlackHole processor (trigger: interval[0:01:00], next run at: 2019-05-02 15:59:10 CEST)" raised a...value in XML from goodreads: `Ausz\xc3\xbcge`
```
xml.parsers.expat.ExpatError: not well-formed (invalid token): line 41, column 1158
Job "BlackHole processor (trigger: interval[0:01:00], next run at: 2019-05-02 15:59:10 CEST)" raised an exception
Traceback (most recent call last):
File "/home/patrick/PycharmProjects/ebookhub-backend/venv/lib/python3.6/site-packages/apscheduler/executors/base.py", line 125, in run_job
retval = job.func(*job.args, **job.kwargs)
File "/home/patrick/PycharmProjects/ebookhub-backend/eBookHub/jobs/blackhole.py", line 157, in process_blackhole_job
list(process_blackhole(os.path.abspath(blackhole_path)))
File "/home/patrick/PycharmProjects/ebookhub-backend/eBookHub/jobs/blackhole.py", line 143, in process_blackhole
saved, new, book_edition_file = handle(blackhole_path, file)
File "/home/patrick/PycharmProjects/ebookhub-backend/eBookHub/jobs/blackhole.py", line 130, in handle
resultset = process_file(filename)
File "/home/patrick/PycharmProjects/ebookhub-backend/eBookHub/jobs/blackhole.py", line 27, in process_file
result = source.parse(book_data_raw['title'], book_data_raw['authors'])
File "/home/patrick/PycharmProjects/ebookhub-backend/eBookHub/source/abstract.py", line 58, in parse
return self.search_title_and_author(title, authors)
File "/home/patrick/PycharmProjects/ebookhub-backend/venv/lib/python3.6/site-packages/flask_caching/__init__.py", line 769, in decorated_function
rv = f(*args, **kwargs)
File "/home/patrick/PycharmProjects/ebookhub-backend/eBookHub/source/goodreads.py", line 40, in search_title_and_author
return self.parse_search_result(self.client.search_book("{} - {}".format(title, author)))
File "/home/patrick/PycharmProjects/ebookhub-backend/eBookHub/source/goodreads.py", line 51, in parse_search_result
result.append(self.book_id(entry['id']["#text"]))
File "/home/patrick/PycharmProjects/ebookhub-backend/venv/lib/python3.6/site-packages/flask_caching/__init__.py", line 769, in decorated_function
rv = f(*args, **kwargs)
File "/home/patrick/PycharmProjects/ebookhub-backend/eBookHub/source/goodreads.py", line 24, in book_id
return self.transformer.convert_book(self.client.Book.show(eid))
File "/home/patrick/PycharmProjects/ebookhub-backend/venv/lib/python3.6/site-packages/goodreads_api_client/resources/book.py", line 31, in show
return self._show_single_resource(id_)
File "/home/patrick/PycharmProjects/ebookhub-backend/venv/lib/python3.6/site-packages/goodreads_api_client/resources/base.py", line 18, in _show_single_resource
res = self._transport.req(endpoint=endpoint, uses_oauth=uses_oauth)
File "/home/patrick/PycharmProjects/ebookhub-backend/venv/lib/python3.6/site-packages/goodreads_api_client/transport.py", line 152, in req
return Transport._transform_res(res, transform)
File "/home/patrick/PycharmProjects/ebookhub-backend/venv/lib/python3.6/site-packages/goodreads_api_client/transport.py", line 140, in _transform_res
content = xmltodict.parse(res.text)
File "/home/patrick/PycharmProjects/ebookhub-backend/venv/lib/python3.6/site-packages/xmltodict.py", line 330, in parse
parser.Parse(xml_input, True)
xml.parsers.expat.ExpatError: not well-formed (invalid token): line 6, column 382
```Patrick van der LeerPatrick van der Leerhttps://gitlab.0x43.nl/0x43/ebookhub-backend/-/issues/24login always returns 2002019-05-09T08:41:01ZMycha de Vreeslogin always returns 200When logging in, request always returns a 200, even when providing false credentials.
Frontend is fetching 'current' user (which is no user at all) also returning a 200, showing all menu items while in reality im not logged in.When logging in, request always returns a 200, even when providing false credentials.
Frontend is fetching 'current' user (which is no user at all) also returning a 200, showing all menu items while in reality im not logged in.https://gitlab.0x43.nl/0x43/ebookhub-backend/-/issues/18load config from ini2019-03-19T11:06:05ZPatrick van der Leerload config from inito make things easier for users to set up, load essentials from ini
http://flask.pocoo.org/docs/0.12/config/to make things easier for users to set up, load essentials from ini
http://flask.pocoo.org/docs/0.12/config/Patrick van der LeerPatrick van der Leerhttps://gitlab.0x43.nl/0x43/ebookhub-backend/-/issues/22Include author when fetching books2019-04-11T12:30:52ZMycha de VreesInclude author when fetching booksIt would be nice to get author information (name and ID) when fetching books
![Screenshot_from_2019-04-11_14-27-02](/uploads/93ee1fd516d556aa696c13a6abed2127/Screenshot_from_2019-04-11_14-27-02.png)
Right now I only get author informat...It would be nice to get author information (name and ID) when fetching books
![Screenshot_from_2019-04-11_14-27-02](/uploads/93ee1fd516d556aa696c13a6abed2127/Screenshot_from_2019-04-11_14-27-02.png)
Right now I only get author information as part of a relationship:
![Screenshot_from_2019-04-11_14-28-31](/uploads/06660ff806206b8c81650d719916213d/Screenshot_from_2019-04-11_14-28-31.png)
As the relationship field is not something I really use in the frontend, could you add the author name and ID to the attributes part if possible?
```json
{
...
'authors': {
'id': 5
'name': 'Hans'
}
}
```
I could use the author ID to go to the author detail view from the books list.Patrick van der LeerPatrick van der Leerhttps://gitlab.0x43.nl/0x43/ebookhub-frontend/-/issues/5Implement table provider2019-04-11T12:25:55ZMycha de VreesImplement table providerTable provider should be implemented
- [ ] Provider which fetches results async
- [ ] Pagination should still work
Improvement
- [ ] Search will need a re-do as search in backend is used per field
- [ ] perPage paginationTable provider should be implemented
- [ ] Provider which fetches results async
- [ ] Pagination should still work
Improvement
- [ ] Search will need a re-do as search in backend is used per field
- [ ] perPage pagination1.0.0Mycha de VreesMycha de Vreeshttps://gitlab.0x43.nl/0x43/ebookhub-backend/-/issues/1Goodreads API python module2019-03-14T14:12:33ZPatrick van der LeerGoodreads API python module* https://pypi.org/project/Goodreads/
* https://pypi.org/project/goodreads-api-client/* https://pypi.org/project/Goodreads/
* https://pypi.org/project/goodreads-api-client/https://gitlab.0x43.nl/0x43/ebookhub-backend/-/issues/4Gitlab CI2019-03-13T10:24:40ZPatrick van der LeerGitlab CIhttps://gitlab.com/pycqa/flake8/blob/master/.gitlab-ci.ymlhttps://gitlab.com/pycqa/flake8/blob/master/.gitlab-ci.ymlPatrick van der LeerPatrick van der Leerhttps://gitlab.0x43.nl/0x43/ebookhub-backend/-/issues/6get latest api function2019-03-19T10:24:42ZPatrick van der Leerget latest api functionPatrick van der LeerPatrick van der Leerhttps://gitlab.0x43.nl/0x43/ebookhub-backend/-/issues/11generate sortable names for books and authors2019-03-19T10:21:47ZPatrick van der Leergenerate sortable names for books and authorsgenerate sortable names for books and authors, requires i18n for [article (grammar)](https://en.wikipedia.org/wiki/Article_(grammar))generate sortable names for books and authors, requires i18n for [article (grammar)](https://en.wikipedia.org/wiki/Article_(grammar))Patrick van der LeerPatrick van der Leerhttps://gitlab.0x43.nl/0x43/ebookhub-frontend/-/issues/1Generate API stuff2019-04-04T19:47:45ZMycha de VreesGenerate API stuffuse this as example
https://api-platform.com/docs/client-generator/vuejs/use this as example
https://api-platform.com/docs/client-generator/vuejs/1.0.0https://gitlab.0x43.nl/0x43/ebookhub-backend/-/issues/3from file (epub/pdf) to data to information2019-03-19T10:43:42ZPatrick van der Leerfrom file (epub/pdf) to data to information```mermaid
graph LR;
A[filename parser];
B[metadata parser];
C{Merge};
E[lookup in sources];
F[validate];
G{compare engine};
G1[single result];
G2[multiple result];
H1[save];
H2[prompt user];
A --> C
B --> C
C --> E
E --> F
F --> G;
G -...```mermaid
graph LR;
A[filename parser];
B[metadata parser];
C{Merge};
E[lookup in sources];
F[validate];
G{compare engine};
G1[single result];
G2[multiple result];
H1[save];
H2[prompt user];
A --> C
B --> C
C --> E
E --> F
F --> G;
G --> G1;
G --> G2;
G1 --> H1;
G2 --> H2;
```Patrick van der LeerPatrick van der Leerhttps://gitlab.0x43.nl/0x43/ebookhub-backend/-/issues/21Filtering results2019-04-11T12:24:42ZMycha de VreesFiltering resultsIt would be nice to filter in a `LIKE` sort of way.
![Screenshot_from_2019-04-11_14-22-21](/uploads/471316bd0b4f5b70083278f80e6ccb48/Screenshot_from_2019-04-11_14-22-21.png)
When filtering by name, it will only find a result based on t...It would be nice to filter in a `LIKE` sort of way.
![Screenshot_from_2019-04-11_14-22-21](/uploads/471316bd0b4f5b70083278f80e6ccb48/Screenshot_from_2019-04-11_14-22-21.png)
When filtering by name, it will only find a result based on the full name. If in this example I would only search for `Sterf`, the resultset will be 0:
![Screenshot_from_2019-04-11_14-24-26](/uploads/8be07153d22184a0153f024b044f3ee4/Screenshot_from_2019-04-11_14-24-26.png)Patrick van der LeerPatrick van der Leerhttps://gitlab.0x43.nl/0x43/ebookhub-backend/-/issues/17external source - caching2019-05-02T13:45:21ZPatrick van der Leerexternal source - cachingAdding a cache on specific object, for example, getting the same other 30 times in the case of a series of books is stupid, we can simply cache the resultAdding a cache on specific object, for example, getting the same other 30 times in the case of a series of books is stupid, we can simply cache the resultPatrick van der LeerPatrick van der Leerhttps://gitlab.0x43.nl/0x43/ebookhub-backend/-/issues/19enable/disable sources2019-03-19T13:17:33ZPatrick van der Leerenable/disable sourcesbeing able to enabled/disabled sources via configbeing able to enabled/disabled sources via configPatrick van der LeerPatrick van der Leerhttps://gitlab.0x43.nl/0x43/ebookhub-frontend/-/issues/4E2E tests2019-03-26T19:57:02ZMycha de VreesE2E testshttps://www.cypress.io/https://www.cypress.io/1.0.0